Add Delayed::Plugins::Pidfile #1202
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new plugin creates a pidfile at location
`#{Rails.root}/tmp/delayed_job.pid` when a worker starts and then
removes it when a worker stops. It uses `lifecycle.around(:execute)` to
achieve this.
The file is created in "write exclusive" mode. This means if the file
already exists, `Errno::EEXIST` is raised. This ensures that a worker
doesn't overwrite a pidfile in use.
This plugin is useful to allow an outside observer (e.g. a healthcheck)
to check if the worker started successfully.
The plugin is not installed by default for backwards compatibility.
Users can use it by adding to their initializer:
Delayed::Worker.plugins << Delayed::Plugin::Pidfile
refs collectiveidea#875
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new plugin creates a pidfile at location
#{Rails.root}/tmp/delayed_job.pidwhen a worker starts and then removes it when a worker stops. It useslifecycle.around(:execute)to achieve this.The file is created in "write exclusive" mode. This means if the file already exists,
Errno::EEXISTis raised. This ensures that a worker doesn't overwrite a pidfile in use.This plugin is useful to allow an outside observer (e.g. a healthcheck) to check if the worker started successfully.
The plugin is not installed by default for backwards compatibility. Users can use it by adding to their initializer:
Delayed::Worker.plugins << Delayed::Plugin::Pidfile
refs #875