Bugfix for encode_with_override psych extension #609
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `coder` passed to ActiveRecord::Base#encode_with does not necessarily have a `tag=` method (it may just be a Hash). This causes issues with other callers, eg https://github.com/Shopify/identity_cache/blob/master/lib/identity_cache/query_api.rb#L140
|
is this patch ok? we have this problem too. |
|
@aaronjensen has been working for us in production, but I would feel a lot better myself if this was looked over by the maintainers and merged. @collectiveidea, does this look alright? |
|
@collectiveidea Had to deal with this too in using IdentityCache. Will this be looked at soon? |
|
thanks for the patch! |
|
Also having issues with IdentityCache and hoping this patch will resolve it. I'm using DJ using the delayed_job_active_record gem. Any suggestions on how I can use this patched version of DJ with the AR gem? |
|
change your gemfile to: |
|
+1 Thanks for the patch @ehsanul! |
|
This patch would help us, too. Please merge. |
|
This does not currently merge. Needs to be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
coderpassed toActiveRecord::Base#encode_withdoes not necessarily havea
tag=method (it may just be aHash). This causes issues with other callers,eg https://github.com/Shopify/identity_cache/blob/master/lib/identity_cache/query_api.rb#L140
Fixes #435