Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding back to gemspec #688

Closed
wants to merge 1 commit into from
Closed

Conversation

JMcG
Copy link

@JMcG JMcG commented Aug 25, 2014

removed in 5f2b46e - will throw invalid multibyte char when loading
gemspec without it

removed in 5f2b46e - will throw invalid multibyte char when loading
gemspec without it
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2324194 on JMcG:master into 9794c97 on collectiveidea:master.

@albus522
Copy link
Member

In what case does this happen?

@JMcG
Copy link
Author

JMcG commented Aug 25, 2014

For me, the error gets thrown when passenger is trying to spawn an application process.

/mnt/app/shared/bundle/ruby/1.9.1/bundler/gems/delayed_job-6fc9000bc0e1/delayed_job.gemspec:3: invalid multibyte char (US-ASCII)
/mnt/app/shared/bundle/ruby/1.9.1/bundler/gems/delayed_job-6fc9000bc0e1/delayed_job.gemspec:3: syntax error, unexpected $end, expecting ']'
...', 'Steve Richert', 'Tobias Lütke']
...                               ^
 (Bundler::GemspecError)) (process 31278, thread #<Thread:0x000000022190b0>):
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler.rb:309:in `rescue in rescue in block in load_gemspec_uncached'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler.rb:297:in `rescue in block in load_gemspec_uncached'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler.rb:293:in `block in load_gemspec_uncached'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler.rb:291:in `chdir'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler.rb:291:in `load_gemspec_uncached'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler.rb:282:in `load_gemspec'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/source.rb:411:in `block in load_spec_files'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/source.rb:410:in `each'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/source.rb:410:in `load_spec_files'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/source.rb:799:in `load_spec_files'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/source.rb:381:in `local_specs'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/source.rb:774:in `specs'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/lazy_specification.rb:53:in `__materialize__'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/spec_set.rb:86:in `block in materialize'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/spec_set.rb:83:in `map!'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/spec_set.rb:83:in `materialize'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/definition.rb:113:in `specs'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/definition.rb:158:in `specs_for'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/definition.rb:147:in `requested_specs'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/environment.rb:23:in `requested_specs'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler/runtime.rb:11:in `setup'
  from /usr/local/rvm/gems/ruby-1.9.3-p125@global/gems/bundler-1.2.1/lib/bundler.rb:116:in `setup'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/utils.rb:326:in `prepare_app_process'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/classic_rails/application_spawner.rb:176:in `block in initialize_server'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/utils.rb:572:in `report_app_init_status'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/classic_rails/application_spawner.rb:174:in `initialize_server'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/abstract_server.rb:204:in `start_synchronously'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/abstract_server.rb:180:in `start'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/classic_rails/application_spawner.rb:149:in `start'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/spawn_manager.rb:219:in `block (2 levels) in spawn_rails_application'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/abstract_server_collection.rb:132:in `lookup_or_add'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/spawn_manager.rb:214:in `block in spawn_rails_application'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/abstract_server_collection.rb:82:in `block in synchronize'
  from <internal:prelude>:10:in `synchronize'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/spawn_manager.rb:213:in `spawn_rails_application'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/spawn_manager.rb:132:in `spawn_application'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/spawn_manager.rb:275:in `handle_spawn_application'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/abstract_server.rb:357:in `server_main_loop'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/lib/phusion_passenger/abstract_server.rb:206:in `start_synchronously'
  from /usr/local/rvm/gems/ruby-1.9.3-p125/gems/passenger-3.0.12/helper-scripts/passenger-spawn-server:99:in `<main>'

@albus522
Copy link
Member

You are using a version of bundler that is almost 2 years old and a version of ruby that is over 2 and a half years old. Both should be upgraded as there have been major security patches and other fixes.

Using a current version of ruby 1.9.3 and bundler should solve your problem given that we still run our tests against 1.9.3

@albus522 albus522 closed this Aug 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants