Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get specs running under rails 4.2.0.beta-1 #692

Closed

Conversation

johnnaegle
Copy link

The 4.2.0.beta-1 specs are failing because the released version rails-deprecated_sanitizer gem includes Rails::Railtie. This is fixed (rails/rails-deprecated_sanitizer#1) but not planned for release.

This change uses the github version of rails-deprecated_sanitizer for 4.2.0.beta1

There is one failing test under 4.2.0.beta-1 when this is merged in.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) when pulling 9ae945c on johnnaegle:feature/rails-4.2.0.beta1 into 7d688a8 on collectiveidea:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9ae945c on johnnaegle:feature/rails-4.2.0.beta1 into 7d688a8 on collectiveidea:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2fa693d on johnnaegle:feature/rails-4.2.0.beta1 into 7d688a8 on collectiveidea:master.

…VERSION is "4.2.0.beta1" or as it is in travis: "~> 4.2.0.beta1"
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5863129 on johnnaegle:feature/rails-4.2.0.beta1 into 7d688a8 on collectiveidea:master.

@albus522
Copy link
Member

Turns out they pulled rails-deprecated_sanitizer as the default configuration for 4.2.

@albus522 albus522 closed this Sep 18, 2014
@albus522
Copy link
Member

Thanks for looking into this though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants