Skip to content

Commit

Permalink
psql :optimized_sql strategy now updates a single row
Browse files Browse the repository at this point in the history
The planner may choose to generate a plan that executes a nested loop over the LIMITing subquery, causing more UPDATEs than LIMIT
  • Loading branch information
jpcuevaslavin committed Aug 7, 2020
1 parent d602a5d commit 88e70bf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/delayed/backend/active_record.rb
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def self.reserve_with_scope_using_optimized_postgres(ready_scope, worker, now)
# use 'FOR UPDATE' and we would have many locking conflicts
quoted_name = connection.quote_table_name(table_name)
subquery = ready_scope.limit(1).lock(true).select("id").to_sql
sql = "UPDATE #{quoted_name} SET locked_at = ?, locked_by = ? WHERE id IN (#{subquery}) RETURNING *"
sql = "WITH pending AS (#{subquery}) UPDATE #{quoted_name} SET locked_at = ?, locked_by = ? FROM pending WHERE #{quoted_name}.id = pending.id RETURNING *"
reserved = find_by_sql([sql, now, worker.name])
reserved[0]
end
Expand Down

0 comments on commit 88e70bf

Please sign in to comment.