Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Mongoid 3 and 4 + fix after_fork callback #81

Merged
merged 3 commits into from Apr 2, 2021

Conversation

johnnyshields
Copy link
Collaborator

@johnnyshields johnnyshields commented Apr 1, 2021

  • Drop support for Mongoid 3 and 4
  • Perform disconnect on after_fork on all Mongoid versions

This gem's code has been quite stable so there's really no reason to continue to support Mongoid 3/4 (Mongoid 4 has been been EOL for 4 years now.)

- Perform disconnect on after_fork on all Mongoid versions
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 88.571% when pulling fce5b3e on johnnyshields:drop-mongoid-3-4 into d915199 on collectiveidea:master.

@coveralls
Copy link

coveralls commented Apr 1, 2021

Coverage Status

Coverage decreased (-0.6%) to 88.571% when pulling 4d80dfe on johnnyshields:drop-mongoid-3-4 into d915199 on collectiveidea:master.

Copy link
Collaborator

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove mongoid_compatibility from .gemspec or is it used elsewhere?

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@johnnyshields
Copy link
Collaborator Author

johnnyshields commented Apr 2, 2021

Can we remove mongoid_compatibility from .gemspec or is it used elsewhere?

I have removed mongoid_compatibility, it's not needed anymore.

@johnnyshields
Copy link
Collaborator Author

Please merge and cut a release

@dblock dblock merged commit db87465 into collectiveidea:master Apr 2, 2021
@dblock
Copy link
Collaborator

dblock commented Apr 2, 2021

Merged. It's nice to see you here @johnnyshields. I added you to the repo maintainers and to rubygems so you can cut the release. Thanks for your help!

@johnnyshields
Copy link
Collaborator Author

Awesome, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants