Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Rollback is called on the failed interactor #2

Closed
wants to merge 1 commit into from

Conversation

brianhempel
Copy link
Contributor

The README should make this clear. :)

The README should make this clear.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b6db187 on brianhempel:patch-1 into * on collectiveidea:master*.

@danielmorrison
Copy link
Member

👍

@laserlemon
Copy link
Collaborator

GRAMMAR 🚓
I think we might have a have/has mixup in the new wording. My kingdom for some squiggly underlines!

@laserlemon
Copy link
Collaborator

Also, please include [ci skip] in your commit message.

@emilford
Copy link
Contributor

Re: Grammar 🚓

I believe using has here is correct. Unless you're wanting to also change the tense of the sentence (i.e., will have) from the original.

@laserlemon
Copy link
Collaborator

the failed interactor and each completed interactor has the opportunity

vs.

the failed interactor and each completed interactor have the opportunity

@laserlemon
Copy link
Collaborator

How's this? #3

@emilford
Copy link
Contributor

have 👍

#3: Sounds good, but maybe separate sentences?

In addition to halting the chain, an organizer will also rollback. The performed interactors, including the failed interactor, are given the opportunity to undo themselves in reverse order.

@laserlemon
Copy link
Collaborator

This may be a moot point, depending on the outcome of #4. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants