Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce generate option to customize output #23

Merged
merged 8 commits into from
May 17, 2024

Commits on May 16, 2024

  1. Allow parameter extraction to recognize new :generate option

    Default the value to `:both` for backwards compatibility. Constraint the value to one of `:service`, `:client`, or `:both` and add spec to cover validation.
    darronschall committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7328704 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8b037c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c847c2c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Implement conditional generation based on generate option value

    Note the differentiation here in client generation based on whether or not a service was also generated. When we have a service class, the client class can simply use the `client_for` DSL. Otherwise, we have to build the client from the service descriptor proto.
    darronschall committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bb21638 View commit details
    Browse the repository at this point in the history
  2. Replace the "import_type_retention" example with "complex_example"

    The complex example exercises more scenarios and will serve us better moving forward. Given that it also demonstrates correct namespace handling of imported types, the "import_type_retention" example was redundant.
    darronschall committed May 17, 2024
    Configuration menu
    Copy the full SHA
    19f2138 View commit details
    Browse the repository at this point in the history
  3. Add specs to cover the various generate= options.

    There's some repeated code between "when specifying the `skip-empty` option" and when specifying the `skip-empty` and `generate=both` options" that we could do a better job of not repeating ourselves...
    darronschall committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8eec604 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e07b742 View commit details
    Browse the repository at this point in the history
  5. Update CHANGELOG.md

    darronschall committed May 17, 2024
    Configuration menu
    Copy the full SHA
    393768e View commit details
    Browse the repository at this point in the history