-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce generate option to customize output #23
Commits on May 16, 2024
-
Allow parameter extraction to recognize new
:generate
optionDefault the value to `:both` for backwards compatibility. Constraint the value to one of `:service`, `:client`, or `:both` and add spec to cover validation.
Configuration menu - View commit details
-
Copy full SHA for 7328704 - Browse repository at this point
Copy the full SHA 7328704View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8b037c - Browse repository at this point
Copy the full SHA a8b037cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c847c2c - Browse repository at this point
Copy the full SHA c847c2cView commit details
Commits on May 17, 2024
-
Implement conditional generation based on
generate
option valueNote the differentiation here in client generation based on whether or not a service was also generated. When we have a service class, the client class can simply use the `client_for` DSL. Otherwise, we have to build the client from the service descriptor proto.
Configuration menu - View commit details
-
Copy full SHA for bb21638 - Browse repository at this point
Copy the full SHA bb21638View commit details -
Replace the "import_type_retention" example with "complex_example"
The complex example exercises more scenarios and will serve us better moving forward. Given that it also demonstrates correct namespace handling of imported types, the "import_type_retention" example was redundant.
Configuration menu - View commit details
-
Copy full SHA for 19f2138 - Browse repository at this point
Copy the full SHA 19f2138View commit details -
Add specs to cover the various
generate=
options.There's some repeated code between "when specifying the `skip-empty` option" and when specifying the `skip-empty` and `generate=both` options" that we could do a better job of not repeating ourselves...
Configuration menu - View commit details
-
Copy full SHA for 8eec604 - Browse repository at this point
Copy the full SHA 8eec604View commit details -
Configuration menu - View commit details
-
Copy full SHA for e07b742 - Browse repository at this point
Copy the full SHA e07b742View commit details -
Configuration menu - View commit details
-
Copy full SHA for 393768e - Browse repository at this point
Copy the full SHA 393768eView commit details