GitHub Action improvements #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By keeping these separate, we can more easily tell at-a-glance what is causing a GitHub action failure. This also allows the `spec` and `standard` rake tasks to run in parallel as separate actions. Previously, the combined action simply ran `rake` which would run specs and then only ran standard when specs passed.
Given our gemspec defines Ruby >= 3.0, let's ensure that's actually true by running our specs across all support versions.
darronschall
force-pushed
the
split-spec-and-standard-actions
branch
from
472b9bf
to
6dedff2
Compare
danielmorrison
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallelize
rake standardandrake specby splitting out separate actions.Add all supported Ruby versions to the spec matrix, to ensure that all specs pass everywhere.