Gnosis Executor Extension #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketman-21
commented
Mar 28, 2024
| emit NewPendingAdmin(pendingAdmin); | ||
| } | ||
|
|
||
| function setAvatar(address _avatar) public onlyAvatar { |
There was a problem hiding this comment.
Do we only want to let the avatar set another avatar here? or should it be the admin
There was a problem hiding this comment.
Yeah, makes sense to replace this with an onlyAdmin() modifier, rather than onlyAvatar().
On that, you currently have this same require statement duplicated multiple times require(msg.sender == admin..., I'd suggest putting this into an onlyAdmin() modifier.
There was a problem hiding this comment.
Hmm on second thought - the admin is the DAOLogic contract, which currently doesn't have a function to setAvatar. I think we should call rq to discuss the intended design here
… help frontends differentiate upgraded contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.