Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挜[BREAKING] 馃挜 Commonjs, module build enhancements #8

Closed
wants to merge 21 commits into from

Conversation

petermikitsh
Copy link
Member

馃挜BREAKING CHANGES 馃挜

For versions 1.2.1 (inclusive) and prior, the distributions were kind of incorrect.

  • The commonjs dist/index.js file had module ES module import/export syntax.
  • The commonjs source files had their css inlined (poor for performance and causes bundle size bloat).
  • The module build couldn't be tree-shaken since {sideEffects: false} was not set in package.json.
  • Both builds missed other opportunities for reducing bundle size, like removing prop types.

This PR addresses all of these things.

@petermikitsh petermikitsh changed the title Commonjs module builds 馃挜[BREAKING] 馃挜 Commonjs, module build enhancements Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant