Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
both in alembic and during creation through sqlalchemy.engine, this is fixed now.
that most of the
ormar
functions are working your database CREATED with ormar (or ormar + alembic)does not have relations and suffer from perspective of performance and data integrity.
ormar
to connect to existing database your performance and integrityshould be fine nevertheless you should update to reflect all future schema updates in your models.
Breaking
alembic
can identify them in db and not depend on db
Meta
class of theModel
does notinclude
metadata
ordatabase
nowModelDefinitionError
will be raised instead of genericAttributeError
.encode/databases
used for running the queries does not have a connection poolfor sqlite backend, meaning that each querry is run with a new connection and there is no way to
enable enforcing ForeignKeys constraints as those are by default turned off on every connection.
This is changed in
ormar
since >=0.9.0 and by default each sqlite3 query has"PRAGMA foreign_keys=1;"
run so now each sqlite3 connection by default enforces ForeignKey constraints including cascades.
Other