Skip to content

collierrgbsitisfise/serverless-webpack-issue

Folders and files

NameName
Last commit message
Last commit date

Latest commit

 

History

3 Commits
 
 
 
 
 
 
 
 
 
 
 
 
 
 

Repository files navigation

example repo for issue: serverless-heaven/serverless-webpack#1439

require preinstalled nvm and unzip

note: dep. 'aws-sdk-q' was used as example cause it is contain 'aws-sdk' as 'peerDep'

Package with node14

  1. use node14
nvm use 14
  1. install packages
npm i
  1. package app
  node_modules/.bin/sls package
  1. unzip created package
  cd .serverless
  unzip serverless-webpack-app.zip
  1. check packages

command:

  npm ls

result:

├── UNMET PEER DEPENDENCY aws-sdk@>= 2.1.5
└─┬ aws-sdk-q@0.0.2
  └── q@1.5.1

command:

  npm ls aws-sdk

result:

  └── (empty)

as expected it is empty cause we forceExlude it

command:

  ls .serverless/node_modules

result:

  aws-sdk-q q

Package with node16

  1. use node14
nvm use 16.16
  1. install packages
npm i
  1. package app
  node_modules/.bin/sls package
  1. unzip created package
  cd .serverless
  unzip serverless-webpack-app.zip
  1. check packages

command:

  npm ls

result:

└── aws-sdk-q@0.0.2

command:

  npm ls aws-sdk

result:

  └─┬ aws-sdk-q@0.0.2
   └── aws-sdk@2.1358.0

^^^ aws-sdk present

wrong! cause we forceExlude it

command:

  .serverless/node_modules

result:

  available-typed-arrays for-each               ieee754                jmespath               which-typed-array
  aws-sdk                function-bind          inherits               q                      xml2js
  aws-sdk-q              get-intrinsic          is-arguments           querystring            xmlbuilder
  base64-js              gopd                   is-callable            sax
  buffer                  has                    is-generator-function  url
  call-bind              has-symbols            is-typed-array         util
  events                 has-tostringtag        isarray                uuid

^^^^ a lot of unexpected packages

Problem statment:

forceExclude does not work correctly with node16(npm v8) in case when excluded packages defined as "peerDep" in list of orignal packages

About

No description, website, or topics provided.

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published