Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/update Nano Filters / AAK lists #117

Closed
DJCrashdummy opened this issue Sep 12, 2017 · 16 comments
Closed

add/update Nano Filters / AAK lists #117

DJCrashdummy opened this issue Sep 12, 2017 · 16 comments
Labels
directory-data changes to basic FilterLists data

Comments

@DJCrashdummy
Copy link
Contributor

DJCrashdummy commented Sep 12, 2017

historical collected:... (the whole story: jspenguin2017/uBlockProtector#237 (comment))

since the 3 (or to be precise 4 - no idea why 2 different new ones) lists are somehow closely related but not exact the same, also the the new ones should be listed.

@collinbarrett collinbarrett added new list directory-data changes to basic FilterLists data labels Sep 13, 2017
@Atavic
Copy link

Atavic commented Sep 17, 2017

I know that the original aak-list won't be updated. Then there's the AAK-Cont that's hailed as
the new one, while jspenguin2017 has his own list that fits nicely with his own uBlock Protector for Chrome and Chromium.

@DJCrashdummy
Copy link
Contributor Author

maybe ditching uBlock Protector List in favor of having both AAK-Cont lists included (linked against each other with a clear note), since uBlock Protector List is designed for a special addon, makes sense...?

@Atavic
Copy link

Atavic commented Sep 27, 2017

Yes, as AAK-Cont has different versions for various webextensions.

@xqk94524
Copy link

is AAK-Cont better than AAK?

I'm a bit confused.

@Atavic
Copy link

Atavic commented Dec 21, 2017

AAK is no more. I do not know if AAK Cont on gitlab is active as uBlockProtector, but the developer is the same one.

@collinbarrett collinbarrett added help wanted please help us resolve and removed help wanted please help us resolve labels Jan 18, 2018
@collinbarrett collinbarrett removed the help wanted please help us resolve label Feb 11, 2018
@collinbarrett collinbarrett changed the title different and new AAK-lists add new AAK-lists Feb 14, 2018
@collinbarrett collinbarrett removed the directory-data changes to basic FilterLists data label Feb 14, 2018
@collinbarrett
Copy link
Owner

Just tried to read through the history of @jspenguin2017 's projects, and I'm super confused. Can anyone provide insight as to which unique lists he/she maintains?

Currently, I have the original Reek AAK (see id 207 here), which I will keep for posterity.

I also have uBlock Protector (see id 83 here), but that looks like it is no more in favor of the nano projects. It looks to me like uBlock Protector should be removed. Or, does @jspenguin2017 still support a fork of the Reek AAK project somewhere?

These lists should be added.

Additionally, a new syntax should be added for Nano per this as well as a new software for Nano.

Thanks for any feedback.

@jspenguin2017
Copy link

jspenguin2017 commented Feb 21, 2018

I maintain "Nano Filters" and "Nano Defender Integration".

"Nano Defender Integration" will not work properly if installed directly.
"uBlock Protector List" should never been listed in the database, nor should "AAK" or "AAK-Cont" as they also depend on their Userscript.

"Nano Filters" are designed for Nano Adblocker but they are already hard coded into assets.json, there is little to no point in listing them here. Similarly, listing uAssets filters is pretty pointless too.

As a side note:

  • "AdBlock Protector List" was renamed to "uBlock Protector List", which was then renamed to "Nano Defender Integration". There is a long story about it, but I think the exact details doesn't matter here.
  • "AdBlock Protector 2 List" is dropped and is no longer available. It was a pure experiment, and I have never claimed otherwise. But that didn't stop some people from telling everyone about it.
  • "AAK-Cont" is also unmaintained and dropped, but build scripts are still available if you wish to build yourself. You may need to fix some reference if Nano Defender ever switch to Nano Build for build tools. I started the project as a community effort to add cross platform support for Nano Defender, but most people took it as a service and expect me to do everything. So I ended up dropping it when the last contributor goes missing for 3 months.

@collinbarrett
Copy link
Owner

collinbarrett commented Feb 21, 2018

Thanks for clarifying. Yeah, I'm still learning this open-source community thing. Thanks for all your work. Many don't have a good grasp on what free and open-source really means. It doesn't mean the developer(s) will do whatever you want them to for you for free. :)

As for the issue in question, I am going to maintain Reek as it was such a mainstay for awhile, with the caveat that it will be made clear that it is discontinued as well as requires the userscript. Similarly, I'd like to maintain the uBlock Protector list, also with the caveat that it is only supported with Nano Defender (and therefore it's built-in userscript).

I'd additionally like to go ahead and index your Nano Filters as well (will be in a separate commit). I plan to show which software and syntaxes each list supports, so I will just ensure those are accurate. FilterLists should be a software/syntax-agnostic discovery tool, so happy to have Nano rolled into the fold. It may help drive a bit of interest to your project.

collinbarrett added a commit that referenced this issue Feb 21, 2018
@collinbarrett collinbarrett changed the title add new AAK-lists add Nano Filters lists Feb 21, 2018
@arufam124
Copy link

can you create a version that does not have a white list because maybe it's a bit of a problem because the white list maybe also has a lot of bad issues and i can not block the wintelist

@collinbarrett
Copy link
Owner

@arufam124 FilterLists does not create or maintain any lists. It is just an index of lists that exist. You will need to contact the maintainer of the list you have a question about or create your own fork if you want a specific list variant.

@Atavic
Copy link

Atavic commented Mar 5, 2018

@arufam124

# Whitelist for Nano Adblocker
# Nothing for now

NanoWhitelist.txt is void. By the way NanoCore is a fork of gorhill's uBo and the entries can be modified by the user.

@jspenguin2017
Copy link

jspenguin2017 commented Mar 5, 2018

I added a special flag that discards non-user whitelists: https://github.com/NanoAdblocker/NanoCore/blob/master/notes/advanced-settings.MD#_nanoignorethirdpartywhitelist-toggleable-experimental
Not sure if this will be useful for @arufam124

@collinbarrett collinbarrett changed the title add Nano Filters lists add Nano Filters / AAK lists Apr 21, 2018
@collinbarrett
Copy link
Owner

addressed in #304 . needs evaluation if any changes/additions are still required prior to closing.

@jspenguin2017
Copy link

jspenguin2017 commented Jun 30, 2018

The syntax extensions are not currently used in the Nano base filters and whitelist filter (for compatibility), however, the script snippet extensions are.

Nano annoyance filter will not work on uBO, out of security concern. Nano Adblocker has privileged filters system, which uBO lacks.

Also, the syntax doc is here: https://github.com/NanoAdblocker/NanoDoc/blob/master/en/FilterSyntax.MD

For home page and issues tracker, I prefer https://github.com/NanoAdblocker/NanoFilters and https://github.com/NanoAdblocker/NanoFilters/issues

Keep in mind that Nano filters won't work out of the box for other adblockers and are already in assets.json of Nano Adblocker, so I'm not sure if listing them would cause confusion.

@collinbarrett collinbarrett changed the title add Nano Filters / AAK lists add/update Nano Filters / AAK lists Aug 21, 2018
@collinbarrett collinbarrett added directory-data changes to basic FilterLists data and removed directory-data changes to basic FilterLists data new data labels Aug 21, 2018
@tsugami1
Copy link

is very2 good:
I see here that too many have a white list and block the google I hope this is not harmful to privacy
but I see that many lists of videos are whitelisted
this resolves my problem on a number of bad adblocker that block videos

@collinbarrett
Copy link
Owner

closing per #564 (comment)

hawkeye116477 pushed a commit to hawkeye116477/FilterLists that referenced this issue Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

No branches or pull requests

7 participants