Adding 378 lists #628
Adding 378 lists #628
Conversation
Codecov Report
@@ Coverage Diff @@
## master #628 +/- ##
======================================
Coverage 89.9% 89.9%
======================================
Files 185 185
Lines 24757 24757
======================================
Hits 22259 22259
Misses 2498 2498Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@DandelionSprout in this committee (data/FilterList.json), travis complains about line 13096 there is no date in the "publishedDate" section
upd = it is written there "publishedDate": "(Domains)" -> In the place of "Domains", the date is needed?
no?
|
Ah, so that was why the build was failing. Thanks for spotting it. 👍 |
|
you forgot to delete again data/FilterListMaintainer.json -> 1188 |
|
The list with ID 1188 was a phantom resulting from miscopying during my info gathering process, so there's no reason to keep that "list" around. So I removed it in its entirety. |
|
Yes. I'm catching on. but the remnants of from this list of, too, need to remove |
|
Ah, okay. I hope I've done so now. |
|
|
ez
|
I've now also made some small changes in various files, reflecting that my main Norwegian list is now a Nordic list. |
It's got 30-ish Malaysian-relevant entries, that I'm aware of.
|
I think @collinbarrett is dead 😞 |
|
lol. not dead. on vacation for U.S. Thanksgiving holiday and went computer-free. back now, but might take me another day to get caught up. thanks for your patience. |
|
@collinbarrett hell, right (recently, black Friday was), you're having (americans) thanksgiving now. my fool |
Holy cow, did I hit a goldmine while researching another repo. 🎉