Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DKM #76

Merged
merged 11 commits into from
Oct 13, 2023
Merged

Add DKM #76

merged 11 commits into from
Oct 13, 2023

Conversation

collinleiber
Copy link
Owner

@collinleiber collinleiber commented Oct 6, 2023

Add the DKM algorithm #57 and fix various bugs #75 , #74 , #72
Add COIL20 and COIL100 datasets

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #76 (b5c5c6e) into main (34bcc85) will increase coverage by 0.54%.
The diff coverage is 98.29%.

❗ Current head b5c5c6e differs from pull request most recent head 3ad6fae. Consider uploading reports for the commit 3ad6fae to get more accurate results

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   89.99%   90.54%   +0.54%     
==========================================
  Files          57       59       +2     
  Lines        7067     7306     +239     
==========================================
+ Hits         6360     6615     +255     
+ Misses        707      691      -16     
Files Coverage Δ
clustpy/__init__.py 100.00% <100.00%> (ø)
clustpy/data/__init__.py 100.00% <ø> (ø)
clustpy/data/real_torchvision_data.py 79.50% <100.00%> (+9.58%) ⬆️
clustpy/deep/__init__.py 100.00% <100.00%> (ø)
clustpy/deep/_utils.py 90.00% <100.00%> (ø)
clustpy/deep/dec.py 100.00% <100.00%> (ø)
clustpy/deep/dipdeck.py 89.25% <100.00%> (-0.47%) ⬇️
clustpy/deep/dipencoder.py 96.78% <100.00%> (+0.31%) ⬆️
clustpy/deep/vade.py 96.85% <100.00%> (+0.01%) ⬆️
clustpy/metrics/confusion_matrix.py 95.55% <100.00%> (ø)
... and 9 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

clustpy/deep/dkm.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Lumik7 Lumik7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Some minor fixes are needed, see the individual comments in the code.

Fix seeding error in deep clustering
@collinleiber collinleiber merged commit a5bacb3 into main Oct 13, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants