Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace thread-unsafe object pools with thread-safe object pools #117

Open
collinsmith opened this issue Sep 22, 2020 · 0 comments
Open

Comments

@collinsmith
Copy link
Owner

63c17b0 added com.riiablo.util.Pool thread safe object pool implementation. It's worth it to go over com.badlogic.gdx.utils.Pool references and find usages that would benefit from a thread safe object pool. While not necessarily an outright bug, some implementations may produce errors if the throughput is high enough (this only occurred when doing an excessive amount of logging ops/sec), so I'm marking this as such to indicate that is important to look at for packages like com.riiablo.io, com.riiablo.mpq, com.riiablo.codec (all packages that may be hit a ton by multiple threads).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant