New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update model_aligner functionality #1177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahojnnes
requested changes
Mar 27, 2021
Thanks Antonios for the fixes, LGTM. |
lucasthahn
pushed a commit
to TNE-ai/colmap
that referenced
this pull request
Aug 17, 2022
* New functionality in model_aligner * Remove unused constructor * Address PR comments * Remove duplicate comments * Fix unit test to work on all platforms * Update similarity_transform.cc Co-authored-by: Antonios Matakos <anmatako@dss.microsoft.us> Co-authored-by: Antonios Matakos <anmatako@microsoft.com> Co-authored-by: Johannes Schönberger <jsch@demuc.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
model_aligner
has been extended with the following additional functionality:database_path
option will use the database instead of an image listestimate_scale
flag.transform_path
option.The different alignment types work as: