Fix radial distortion in Cam format exporter #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The radial distortion parameters exported by the *.cam file format exporter are currently not computed properly. This PR fixes the
Reconstruction::ExportCam()exporter so that the radial distortion parameters in *.cam files will accurately reflect the same distortion as in COLMAP.If both of the two exported radial distortion parameters in a *.cam file are non-zero, then they are used in a distortion model very similar to the COLMAP and Bundler distortion models. However, if only the second parameter is non-zero, then a different camera model (similar to VisualSFM) is assumed for *.cam files.