Keep precision in the process of storing in text. #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. However, I don’t think we need the std::fixed and can save us some bytes on disk. Also, I suggest to use the full 17 digits precision for the 2D points to ensure identical results to the binary format. Thanks! |
|
Thanks! |
lucasthahn
pushed a commit
to TNE-ai/colmap
that referenced
this pull request
Aug 17, 2022
* Keep precision in the process of storing in text. * Remove std::fix and use the full 17 digits precision for all double varaibles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing variables to std::ostringstream, we will loose precision of double variables if output manipulators were not applied.