Add ReprojErrorConstantPoint3DCostFunction to speed up the RefineAbsolutePose function #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. How much faster is this in practice for the two proposed changes? |
ahojnnes
requested changes
Aug 1, 2023
The average speed up is about 12%. The time taken by both methods is output in SpeedUpLog.txt in the following format. CSV format: |
ahojnnes
reviewed
Aug 1, 2023
ahojnnes
reviewed
Aug 1, 2023
ahojnnes
reviewed
Aug 1, 2023
|
Could you please add a unit test for this new cost function in the cost_function_test.cc file? Thanks. |
My pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new costfunction-ReprojErrorConstantPoint3DCostFunction to speed up the RefineAbsolutePose function.