cmake: add testing.cc to colmap_util only if TESTS_ENABLED=ON #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditionally add the files `testing.h` and `testing.cc` to the library target `colmap_util` only if `TESTS_ENABLED=ON`. Otherwise one needs the `gtest/gtest.h` header available, for example by installing the Debian package `libgtest-dev`, even though no tests are actually built. Using the `target_sources()` function (Introduced with CMake 3.1`) to conditionally add the two testing files to the util target. https://cmake.org/cmake/help/latest/command/target_sources.html Fixes: colmap#2101
|
Thanks, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally add the files
testing.handtesting.ccto the library targetcolmap_utilonly ifTESTS_ENABLED=ON.Otherwise one needs the
gtest/gtest.hheader available, for example by installing the Debian packagelibgtest-dev, even though no tests are actually built.Using the
target_sources()function (Introduced with CMake 3.1`) to conditionally add the two testing files to the util target.https://cmake.org/cmake/help/latest/command/target_sources.html
Fixes: #2101