Setting clear_points to true per default in point_triangulator #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, that makes sense! |
borovik135
pushed a commit
to borovik135/colmap
that referenced
this pull request
Nov 6, 2023
…#2252) Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making sure that image_ids between a model and the database are consistent is a pain. The
clear_pointsflag takes care of this by assigning the correct image_ids to images (consistent with the database) based on filenames. This makes things much easier for casual users, who don't need to read out the image_ids from the database. I would argue that enabling this by default is the better choice (especially since in many cases, one would re-triangulate from scratch anyways).The PR sets the default value to true. It also adds a bit of documentation about the behavior described above to the
--helpargument.If you prefer to keep
clear_pointsset to false by default, I would suggest to add another flag that makes recomputing image_ids default behavior.