Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared EIGEN_STL_UMAP error when building from source #143

Closed
nnop opened this issue Jun 5, 2023 · 3 comments · Fixed by #144
Closed

Undeclared EIGEN_STL_UMAP error when building from source #143

nnop opened this issue Jun 5, 2023 · 3 comments · Fixed by #144

Comments

@nnop
Copy link
Contributor

nnop commented Jun 5, 2023

Hi, guys. I'm building pycolmap from source and met many error of undeclared EIGEN_STL_UMAP:

/home/nnop/codes/pycolmap/reconstruction/camera.cc:22:22: error: ‘EIGEN_STL_UMAP’ was not declared in this scope; did you mean ‘EIGEN_OS_MAC’?                                                                                    
  22 | PYBIND11_MAKE_OPAQUE(EIGEN_STL_UMAP(colmap::camera_t, colmap::Camera));                                                                                                                                                  

I searched the source code of colmap and Eigen and didn't find any declaration of EIGEN_STL_UMAP.
BTW, I've installed the latest version of colmap(commit 079b8ad).
My env: Ubuntu 20.04, libeigen3-dev.

Can't figure out where does the problem come from. Looking forward for your help.

@nnop nnop changed the title Error when building from source Undeclared EIGEN_STL_UMAP error when building from source Jun 5, 2023
@ducha-aiki
Copy link

It is the recent colmap commit, which breaks the pycolmap...

@nnop
Copy link
Contributor Author

nnop commented Jun 5, 2023

Thanks for the hint.
I found It's colmap PR#1947 that Remove unnecessary custom Eigen aligned allocator macros breaks the pycolmap compilation.

@joshuaoreilly
Copy link

joshuaoreilly commented Jun 8, 2023

Until that PR goes through, my workaround was to checkout and build with commit 9eddf2e4; release 3.8 is too old and suffers from Issue 1742, and the current dev branch is waiting on colmap PR#1947, but the linked commit is new enough to avoid the former and old enough to avoid the latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants