Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind Iterative Global SfM #273

Closed
jytime opened this issue Apr 23, 2024 · 2 comments
Closed

Bind Iterative Global SfM #273

jytime opened this issue Apr 23, 2024 · 2 comments

Comments

@jytime
Copy link

jytime commented Apr 23, 2024

Hi,

I was wondering is it possible to bind the IterativeGlobalRefinement function or something similar? We are currently using the bundle adjustment of pycolmap for the iterative_global_BA function in our repository. The function is called here.

It works well and the performance is reasonable. However, since pycolmap.bundle_adjustment currently does not cover the operations like Retriangulate or FilterPoints, we are compelled to convert the data between PyTorch tensors and pycolmap objects for each iteration. We suspect this might not be the most efficient approach.

I have observed that this appears to be a common use case for many users (e.g., #269, #272). I could help write this if it is helpful.

Best,
Jianyuan

@sarlinpe
Copy link
Collaborator

Hi Jianyuan,
This binding is actually available in COLMAP's main branch since colmap/colmap@0ea2d5c. If you need more fine-grained control over the BA setup, feel free to try colmap/colmap#2509 and to leave comments if you have suggestions.

@jytime
Copy link
Author

jytime commented Apr 23, 2024

Hi thanks for the quick update! I will look at it :)

@jytime jytime closed this as completed Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants