-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update utilities #1663
Draft
tomaszkax86
wants to merge
44
commits into
dev
Choose a base branch
from
dev-utilities-update
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update utilities #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k to steady_clock
We have DEV_BUILD and we have COLOBOT_DEVELOPMENT_MODE. It was unclear to me which does what and which one I should use. It turned out that DEV_BUILD has exactly the same effect as PORTABLE_SAVES. I removed the DEV_BUILD option to reduce confusion.
… to COLOBOT_MSVC_STATIC_RUNTIME
|
It should. High-res clock isn't guaranteed to be monotonic and can be aliased to system clock. So it can go back in time when the system randomly chooses to update the system clock. Steady clock is guaranteed to be monotonic and never go back in time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests updates a variety of CMake and system utilities.
General list of changes:
std::chrono::steady_clock
instead ofstd::chrono::high_resolution_clock
. This fixes a problem with negative time counter differences.