Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-op #1670

Merged
merged 1 commit into from
May 19, 2024
Merged

Remove no-op #1670

merged 1 commit into from
May 19, 2024

Conversation

hexagonrecursion
Copy link
Contributor

@hexagonrecursion hexagonrecursion commented May 13, 2024

This two lines of code used to have a purpose, but refactroing (8e01a20) turned them into a no-op

res = m_prog->GetExternalCalls()->DoCall(nullptr, nullptr, ppVar, this, rettype);
if (res >= 0) return res;

is no-op because DoCall(nullptr, ...) returns -1

int CBotExternalCallList::DoCall(CBotToken* token, CBotVar* thisVar, CBotVar** ppVar, CBotStack* pStack,
const CBotTypResult& rettype)
{
if (token == nullptr)
return -1;

This two lines of code used to have a purpose, but refactroing (8e01a20) turned them into a no-op
@hexagonrecursion hexagonrecursion marked this pull request as ready for review May 13, 2024 07:23
@tomaszkax86 tomaszkax86 merged commit d56c7db into colobot:dev May 19, 2024
10 checks passed
@hexagonrecursion hexagonrecursion deleted the patch-2 branch May 22, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants