Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add Schema\Grammar::typeDouble for better compatibility #97

Merged
merged 5 commits into from
May 1, 2023
Merged

feature: add Schema\Grammar::typeDouble for better compatibility #97

merged 5 commits into from
May 1, 2023

Conversation

taka-oyama
Copy link
Collaborator

@taka-oyama taka-oyama commented May 1, 2023 •
edited
Loading

Checklist

  • CHANGELOG

@taka-oyama taka-oyama added this to the v5.1 milestone May 1, 2023
@taka-oyama taka-oyama self-assigned this May 1, 2023
@taka-oyama taka-oyama requested a review from Uyan712 May 1, 2023 01:01
tyabu12
tyabu12 suggested changes May 1, 2023
View reviewed changes
src/Schema/Grammar.php Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
taka-oyama and others added 2 commits May 1, 2023 10:49
@taka-oyama @tyabu12
Update CHANGELOG.md
f97e8de 
Co-authored-by: Tomohito YABU <tyabu1212@gmail.com>
@taka-oyama @tyabu12
Apply suggestions from code review
5e7fa67 
Co-authored-by: Tomohito YABU <tyabu1212@gmail.com>
tyabu12
tyabu12 reviewed May 1, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@taka-oyama @tyabu12
Update CHANGELOG.md
9b3620b 
Co-authored-by: Tomohito YABU <tyabu1212@gmail.com>
@taka-oyama taka-oyama added the enhancement New feature or request label May 1, 2023
tyabu12
tyabu12 approved these changes May 1, 2023
View reviewed changes
Copy link
Contributor

@tyabu12 tyabu12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taka-oyama taka-oyama merged commit 4516732 into master May 1, 2023
@taka-oyama taka-oyama deleted the feature/type-double branch May 1, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyabu12 tyabu12 tyabu12 approved these changes

@dkkoma dkkoma Awaiting requested review from dkkoma

@kt81 kt81 Awaiting requested review from kt81

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi

@halnique halnique Awaiting requested review from halnique

@ojikeii ojikeii Awaiting requested review from ojikeii

@yut-arai yut-arai Awaiting requested review from yut-arai

@t-matsuno-777 t-matsuno-777 Awaiting requested review from t-matsuno-777

@Uyan712 Uyan712 Awaiting requested review from Uyan712

Assignees

@taka-oyama taka-oyama

Labels
enhancement New feature or request
Projects
None yet
Milestone
v5.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@taka-oyama @tyabu12