Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CJS file to /fn entry and fix legacy builds #349

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Add CJS file to /fn entry and fix legacy builds #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 3 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,7 @@
"version": "0.4.5",
"description": "Let’s get serious about color",
"files": [
"dist/color.cjs",
"dist/color.cjs.map",
"dist/color.js",
"dist/color.js.map",
"dist/color.legacy.cjs",
"dist/color.legacy.cjs.map",
"dist/color.legacy.js",
"dist/color.legacy.js.map",
"dist/",
"src/",
"types/dist/",
"types/src/",
Expand All @@ -24,7 +17,8 @@
},
"./fn": {
"types": "./types/src/index-fn.d.ts",
"import": "./src/index-fn.js"
"import": "./src/index-fn.js",
"require": "./dist/color-fn.cjs"
},
"./dist/*": "./dist/*"
},
Expand Down
54 changes: 38 additions & 16 deletions rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import terser from "@rollup/plugin-terser";

let bundles = [
const bundles = [
{
"file": "dist/color.global.js",
"format": "iife",
Expand All @@ -20,22 +20,44 @@ let bundles = [
},
];

const fnBundles = [
{
"file": "dist/color-fn.cjs",
"format": "cjs",
"sourcemap": true,
"exports": "named",
},
];

// Add minified versions of every bundle
bundles = bundles.flatMap(bundle => {
let minBundle = Object.assign({}, bundle);
minBundle.file = minBundle.file.replace(/\.\w+$/, ".min$&");
minBundle.plugins ||= [];
minBundle.plugins.push(terser());
const addMinBundle = (bundles) => {
return bundles.flatMap(bundle => {
const minBundle = Object.assign({}, bundle);
minBundle.file = minBundle.file.replace(/\.\w+$/, ".min$&");
minBundle.plugins ||= [];
minBundle.plugins.push(terser());

return [bundle, minBundle];
});
return [bundle, minBundle];
});
};

export default {
input: "src/index.js",
output: bundles,
onwarn (warning, rollupWarn) {
if (warning.code !== "CIRCULAR_DEPENDENCY") {
rollupWarn(warning);
export default [
{
input: "src/index.js",
output: addMinBundle(bundles),
onwarn (warning, rollupWarn) {
if (warning.code !== "CIRCULAR_DEPENDENCY") {
rollupWarn(warning);
}
}
}
};
},
{
input: "src/index-fn.js",
output: addMinBundle(fnBundles),
onwarn (warning, rollupWarn) {
if (warning.code !== "CIRCULAR_DEPENDENCY") {
rollupWarn(warning);
}
}
},
];
20 changes: 11 additions & 9 deletions rollup.legacy.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,17 @@ import { nodeResolve } from "@rollup/plugin-node-resolve";
import defaultConfig from "./rollup.config.js";

const legacyPlugins = [
commonjs(),
nodeResolve(),
commonjs({ strictRequires: true }),
nodeResolve({ ignoreSideEffectsForRoot: true }),
babel({ babelHelpers: "bundled", exclude: "node_modules/**" }),
];

export default Object.assign(defaultConfig, {
output: defaultConfig.output.map(bundle => ({
...bundle,
file: bundle.file.replace(/\.(?:min\.)?\w+$/, ".legacy$&"),
})),
plugins: [...(defaultConfig.plugins || []), ...legacyPlugins]
});
export default defaultConfig.map(config =>
Object.assign(config, {
output: config.output.map(bundle => ({
...bundle,
file: bundle.file.replace(/\.(?:min\.)?\w+$/, ".legacy$&"),
})),
plugins: [...(config.plugins || []), ...legacyPlugins]
})
);