Fix Jzazbz tests #366
Merged
Fix Jzazbz tests #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first two test cases were miscalculated. Results were verified with the official Matlab script: https://opticapublishing.figshare.com/articles/code/JzAzBz_m/5016299
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Matlab results (ran in Octave) $ octave JzAzBz.m 0.5 0 0 r
7.986956580720049 8.397691849554391 9.136922264117219
$ octave JzAzBz.m 1 0 0 r
48.18778523187121 50.66587844819365 55.12588472139780
$ octave JzAzBz.m 0.1 -0.05 0.05 r
1.085180997761661e-01 1.728735677282366e-01 7.493722855985464e-02 |
|
I requested a review from @svgeesus since that's his domain, but I'm curious to hear your experience using the new testsuite! |
svgeesus
approved these changes
Nov 28, 2023
jgerigmeyer
added a commit
to oddbird/color.js
that referenced
this pull request
Nov 29, 2023
* main: More consistent formatting across the codebase. (color-js#372) More accurate ICtCp matrices (color-js#365) Fix Jzazbz tests (color-js#366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first two test cases were miscalculated. Results were verified with the official Matlab script:
https://opticapublishing.figshare.com/articles/code/JzAzBz_m/5016299