Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color spaces for Luv and LCHuv #391

Merged
merged 1 commit into from Feb 3, 2024
Merged

Conversation

lloydk
Copy link
Collaborator

@lloydk lloydk commented Feb 2, 2024

Add color spaces for Luv and LCHuv.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit 2b001c0
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/65bea67aca8c1b00083d499b
😎 Deploy Preview https://deploy-preview-391--colorjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'll also request a review from @svgeesus.
Thanks so much for your patience and persistence working on this!

@LeaVerou
Copy link
Member

LeaVerou commented Feb 2, 2024

Also requesting reviews from @jgerigmeyer and @MysteryBlokHed for the TS stuff.

Copy link
Member

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great; nicely done!

Copy link
Member

@MysteryBlokHed MysteryBlokHed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript changes LGTM

@LeaVerou
Copy link
Member

LeaVerou commented Feb 3, 2024

@lloydk can you please resolve conflicts so we can merge? Thanks!

@lloydk
Copy link
Collaborator Author

lloydk commented Feb 3, 2024

@lloydk can you please resolve conflicts so we can merge? Thanks!

done

@LeaVerou LeaVerou merged commit 821dba0 into color-js:main Feb 3, 2024
4 checks passed
@LeaVerou
Copy link
Member

LeaVerou commented Feb 3, 2024

Merged, thanks!

@lloydk lloydk deleted the luv-lchuv branch March 15, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants