Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Fix "Defined in" API links #423

Merged
merged 1 commit into from Feb 11, 2024

Conversation

MysteryBlokHed
Copy link
Member

Currently, the API links on the webpage go to non-existent files on the mavoweb/mavo repository instead of this one. For example, this link goes to https://github.com/mavoweb/mavo/blob/master/src/color.js:

A screenshot of the API page on colorjs.io. There is a hyperlink on the right, labelled "Defined in color.js"

This PR fixes the API's index.njk file to have the correct link at the base.

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for colorjs ready!

Name Link
🔨 Latest commit 101c5dd
🔍 Latest deploy log https://app.netlify.com/sites/colorjs/deploys/65c9045f2b27140008b799a2
😎 Deploy Preview https://deploy-preview-423--colorjs.netlify.app/api
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow 🤣 how did this go undetected for so long?! Thanks for catching it!

@MysteryBlokHed MysteryBlokHed merged commit 4cf563f into color-js:main Feb 11, 2024
4 checks passed
@MysteryBlokHed MysteryBlokHed deleted the website/fix-api-links branch February 11, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants