Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make crate MSVR 1.63 #146

Merged
merged 7 commits into from
Jul 5, 2023
Merged

Make crate MSVR 1.63 #146

merged 7 commits into from
Jul 5, 2023

Conversation

hwittenborn
Copy link
Member

No description provided.

@hwittenborn
Copy link
Member Author

I'd like you to review this before it gets merged @kurtlawrence, especially the version policy for when the MSRV gets bumped (see README.md in the changed files).

If you don't think the minor version approach is good I'm down for discussing alternatives.

@hwittenborn hwittenborn linked an issue Jul 5, 2023 that may be closed by this pull request
Whats the MSRV for this crate? #85
Closed
@hwittenborn hwittenborn changed the title Make crate MSVR 1.6 Make crate MSVR 1.62 Jul 5, 2023
@hwittenborn hwittenborn changed the title Make crate MSVR 1.62 Make crate MSVR 1.63 Jul 5, 2023
@hwittenborn hwittenborn mentioned this pull request Jul 5, 2023
Closed
LingMan
LingMan reviewed Jul 5, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hwittenborn and others added 3 commits July 4, 2023 21:46
@hwittenborn @LingMan
Change wordage on CHANGELOG.md
fe72b5f 
Co-authored-by: LingMan <LingMan@users.noreply.github.com>
@hwittenborn @LingMan
Updated wordage in README.md
31f1d26 
Co-authored-by: LingMan <LingMan@users.noreply.github.com>
@hwittenborn
Simply and fix GitHub Actions config
0431017
@hwittenborn
Copy link
Member Author

Are you a regular contributor to the crate @LingMan? It seems like you're quite good at reviewing stuff, and I'd like to add you to here somehow (even if just as a reviewer) if you'd be down with it :).

LingMan
LingMan reviewed Jul 5, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@LingMan
Copy link
Contributor

LingMan commented Jul 5, 2023 •
edited

Are you a regular contributor to the crate @LingMan?

You mean to colored? So far I have a grand total of zero commits merged here. No clue how any of it works either, so adding me as a reviewer is not something I'd advise to do.

@hwittenborn
Copy link
Member Author

Alright that sounds good @LingMan, just throwing it out as an offer! If you ever want to I'm definitely down though :)

@hwittenborn
Change matrix order in GitHub Actions test workflow
0f15c39 
Just makes the order of tests a bit more organized
@hwittenborn hwittenborn mentioned this pull request Jul 5, 2023
Merged
LingMan
LingMan reviewed Jul 5, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
kurtlawrence
kurtlawrence approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@kurtlawrence kurtlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hwittenborn
Copy link
Member Author

Sounds great! I'll go ahead and get this merged then :)

@hwittenborn hwittenborn merged commit 6b446bb into master Jul 5, 2023
5 checks passed
@hwittenborn hwittenborn deleted the msrv branch July 5, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LingMan LingMan LingMan approved these changes

@kurtlawrence kurtlawrence kurtlawrence approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Whats the MSRV for this crate?
3 participants
@hwittenborn @LingMan @kurtlawrence