Fix issues from scrutiniser inspection results.

colour-science · Nov 7, 2017 · 98b5272 · 98b5272
1 parent 7af1e1a
commit 98b5272
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 5 deletions.
diff --git a/colour/continuous/abstract.py b/colour/continuous/abstract.py
@@ -150,7 +150,7 @@ def _get_dtype(self):
             Abstract continuous function dtype.
         """
 
-        return self._dtype
+        pass
 
     def _set_dtype(self, value):
         """
@@ -160,6 +160,8 @@ def _set_dtype(self, value):
 
         pass
 
+    domain = abstractproperty(_get_dtype, _set_dtype)
+
     def _get_domain(self):
         """
         Getter and setter property for the abstract continuous function
@@ -694,7 +696,7 @@ def __ipow__(self, a):
         return self.arithmetical_operation(a, '**', True)
 
     @abstractmethod
-    def arithmetical_operation(self, a, operation, in_place):
+    def arithmetical_operation(self, a, operation, in_place=False):
         """
         Performs given arithmetical operation with :math:`a` operand, the
         operation can be either performed on a copy or in-place, must be

diff --git a/colour/continuous/signal.py b/colour/continuous/signal.py
@@ -845,6 +845,21 @@ def _create_function(self):
         else:
 
             def _undefined_function(*args, **kwargs):
+                """
+                Raises a `RuntimeError` exception.
+
+                Other Parameters
+                ----------------
+                \*args : list, optional
+                    Arguments.
+                \**kwargs : dict, optional
+                    Keywords arguments.
+
+                Raises
+                ------
+                RuntimeError
+                """
+
                 raise RuntimeError(
                     'Underlying signal interpolator function does not exists, '
                     'please ensure you defined both '

diff --git a/colour/continuous/tests/test_signal.py b/colour/continuous/tests/test_signal.py
@@ -475,12 +475,12 @@ def test_arithmetical_operation(self):
 
         np.testing.assert_array_almost_equal(
             signal.arithmetical_operation(self._range, '+', False).range,
-            signal._range + self._range,
+            signal.range + self._range,
             decimal=7)
 
         np.testing.assert_array_almost_equal(
             signal.arithmetical_operation(signal, '+', False).range,
-            signal._range + signal._range,
+            signal.range + signal._range,
             decimal=7)
 
     def test_is_uniform(self):

diff --git a/colour/utilities/tests/test_array.py b/colour/utilities/tests/test_array.py
@@ -237,7 +237,7 @@ def test_interval(self):
         np.testing.assert_almost_equal(
             interval([1, 2, 3, 4, 6, 6.5]), np.array([0.5, 1.0, 2.0]))
 
-        self.equal = np.testing.assert_almost_equal(
+        np.testing.assert_almost_equal(
             interval([1, 2, 3, 4, 6, 6.5], False),
             np.array([1.0, 1.0, 1.0, 2.0, 0.5]))