Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "Luminous Flux" computation. #40

Closed
KelSolaar opened this issue May 12, 2014 · 2 comments · Fixed by #162
Closed

Implement "Luminous Flux" computation. #40

KelSolaar opened this issue May 12, 2014 · 2 comments · Fixed by #162

Comments

@KelSolaar KelSolaar added this to the v0.2.1 milestone Jul 28, 2014
@KelSolaar KelSolaar added P2 and removed P2 labels Aug 14, 2014
@KelSolaar KelSolaar modified the milestones: v0.2.1, v9.9.9 Aug 27, 2014
@canavandl
Copy link
Contributor

I'm interested in implementing this, but i had a few questions about how to best do it. I see that generating all of the relevant lefs as already been implemented, so all that's left is writing the general luminous flux function.

It's unclear to me how to best implement the integration by parts to do the inner product. As far as I'm aware, numpy doesn't have a general integration function that runs a length n-1 array of the integration pieces (please correct me if I'm wrong). I could write something add something to .colour/algebra/common.py but I don't want to assume that everybody would want to use trapezoidal integration. I could add the options of left-rule, right-rule, etc. but that gets busy quick.

I'd appreciate any advice.

@KelSolaar
Copy link
Member Author

Hi Luke,

I haven't checked in details but you should be able to avoid the integration by doing a summation like we do it for spectral conversion. Just found this link, I think it should help: http://hyperphysics.phy-astr.gsu.edu/hbase/vision/lumpow.html

canavandl added a commit to canavandl/colour that referenced this issue Sep 26, 2014
…mplementation utilizes left-hand integration.
@KelSolaar KelSolaar changed the title Implement "Luminous Flux" calculation. Implement "Luminous Flux" computation. Oct 3, 2014
KelSolaar pushed a commit that referenced this issue Oct 3, 2014
This implementation uses left-hand integration.

Closes #40.
@KelSolaar KelSolaar modified the milestones: v0.3.3, v9.9.9 Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants