Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement support for "IPT" colourspace. #115

Merged
merged 5 commits into from
Sep 3, 2014
Merged

Conversation

MichaelMauderer
Copy link
Member

Implements conversions between XYZ and IPT colourspaces, as well as an IPT hue correlate.

Closes #114.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) when pulling ec38713 on feature/ipt into d44662b on develop.

@KelSolaar
Copy link
Member

Overall it's nitpicking comments, the only real issue is for the IPT_to_XYZ definition name.

For consistency, I don't mind we do units tests also, I can write them if you want!

@KelSolaar
Copy link
Member

Reminds me that I need to ask JetBrains for a PyCharm Open Source license!

Aligned first line of reference to next tab.
Instead of repeating the main reference in each function, it is now cited using standard reST citations
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) when pulling 4eb03a4 on feature/ipt into d44662b on develop.

@MichaelMauderer
Copy link
Member Author

I think I have addressed everything raised by you (good and valid points!)

I am not entirely sure about the referencing scheme that I now use.
Basically I am just citing the reference in the header (which is what it is there for). But it doesn't feel quite right. Maybe it should go into an extended description, where there is more detail and then the reference to the paper?

Oh neat Open Source licenses! Wasn't aware of that.

@KelSolaar
Copy link
Member

Awesome! Thanks :) I will probably run PyCharm reformat on it later.

As for the extended description, I would suggest that you do that in the IPython Notebooks, for instance link the notebook like that: https://github.com/colour-science/colour/blob/feature/v0.3.3/colour/colorimetry/lightness.py#L19
and have fun: http://nbviewer.ipython.org/github/colour-science/colour-ipython/blob/master/notebooks/colorimetry/lightness.ipynb

I'm doing the luminance one as we are speaking, and it should close the colorimetry chapter.

KelSolaar added a commit that referenced this pull request Sep 3, 2014
PR: Implement support for "IPT" colourspace.
@KelSolaar KelSolaar merged commit 23bf4e3 into develop Sep 3, 2014
@KelSolaar KelSolaar deleted the feature/ipt branch September 3, 2014 18:52
@KelSolaar KelSolaar added this to the v0.3.3 milestone Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement support for "IPT" colourspace.
3 participants