-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Implement support for "IPT" colourspace. #115
Conversation
Closes #114.
Overall it's nitpicking comments, the only real issue is for the For consistency, I don't mind we do units tests also, I can write them if you want! |
Reminds me that I need to ask JetBrains for a PyCharm Open Source license! |
Aligned first line of reference to next tab. Instead of repeating the main reference in each function, it is now cited using standard reST citations
I think I have addressed everything raised by you (good and valid points!) I am not entirely sure about the referencing scheme that I now use. Oh neat Open Source licenses! Wasn't aware of that. |
Awesome! Thanks :) I will probably run PyCharm reformat on it later. As for the extended description, I would suggest that you do that in the IPython Notebooks, for instance link the notebook like that: https://github.com/colour-science/colour/blob/feature/v0.3.3/colour/colorimetry/lightness.py#L19 I'm doing the luminance one as we are speaking, and it should close the colorimetry chapter. |
PR: Implement support for "IPT" colourspace.
Implements conversions between
XYZ
andIPT
colourspaces, as well as anIPT
hue correlate.Closes #114.