Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement missing number of terms from Cheung's (2004) polynomial transforms #1160

Merged
merged 1 commit into from Jun 1, 2023

Conversation

chnmasta05
Copy link

Summary

Fixes #616.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • [N/A] New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@chnmasta05 chnmasta05 changed the title Add missing number of terms for polynomial regressions Implement missing number of terms from Cheung's (2004) polynomial transforms May 31, 2023
@chnmasta05 chnmasta05 changed the title Implement missing number of terms from Cheung's (2004) polynomial transforms PR: Implement missing number of terms from Cheung's (2004) polynomial transforms May 31, 2023
@KelSolaar KelSolaar self-requested a review June 1, 2023 08:17
@KelSolaar KelSolaar added this to the v0.4.3 milestone Jun 1, 2023
@KelSolaar KelSolaar merged commit 7bdc09e into colour-science:develop Jun 1, 2023
13 checks passed
@KelSolaar
Copy link
Member

Awesome and thanks a lot @chnmasta05!

@KelSolaar
Copy link
Member

Do you have a contributor name you would like for citation purposes? https://zenodo.org/record/7367239

@chnmasta05 chnmasta05 deleted the feature/cheung2004 branch June 1, 2023 08:24
@chnmasta05
Copy link
Author

Thank you! Please use Xiaohan Chen as my name, where Chen is the surname.

@KelSolaar
Copy link
Member

Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cheung (2004): Transforms with 4 and 35 terms not implemented.
3 participants