Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement support for "Canon" v1.2 encodings. #1182

Merged
merged 1 commit into from Jul 19, 2023

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented Jul 16, 2023

Summary

This PR implements support for Canon v1.2 encodings that define their constants in legal range. Minor numerical differences because of the rounding of the constants are expected.

References #1176.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • [N/A] New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@coveralls
Copy link

coveralls commented Jul 16, 2023

Coverage Status

coverage: 99.775% (+0.002%) from 99.773% when pulling 788593e on feature/canon_log_v1.2 into ca0bba3 on develop.

@KelSolaar KelSolaar added this to the v0.4.3 milestone Jul 17, 2023
@KelSolaar KelSolaar merged commit 1966033 into develop Jul 19, 2023
26 checks passed
@KelSolaar KelSolaar deleted the feature/canon_log_v1.2 branch July 19, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants