PR: Overhaul unit tests to use np.testing.assert_allclose
definition.
#1231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR overhauls the unit tests to use
np.testing.assert_allclose
definition. We have been suffering hard to reproduce precision loss issues during multi-threaded unit tests and usingnp.testing.assert_allclose
definition helps alleviate it, albeit in a disappointing way. With that said,np.testing.assert_allclose
is recommended by Numpy overnp.testing.assert_array_almost_equal
thus this is a welcome switch.Preflight
Code Style and Quality
colour
,colour.models
.Documentation