Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement support for "Munish Ragoo and Farup (2021)" "Optimised IPT" Colourspace. #990

Merged
merged 2 commits into from May 27, 2022

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented May 25, 2022

Summary

This PR implements support for the Optimised IPT colourspace by Munish Ragoo and Farup (2021).

I took that opportunity to refactor most of the IPT-like colourspaces using shared definitions, i.e. colour.models.XYZ_to_Iab and colour.models.Iab_to_XYZ.

References

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Mypy static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar requested a review from a team May 25, 2022 10:24
@KelSolaar KelSolaar added this to the v0.4.2 milestone May 25, 2022
@coveralls
Copy link

coveralls commented May 25, 2022

Coverage Status

Coverage increased (+0.0006%) to 99.854% when pulling 24656e6 on feature/ragoo2021 into 1a304f6 on develop.

@KelSolaar KelSolaar merged commit a9e0f4d into develop May 27, 2022
@KelSolaar KelSolaar deleted the feature/ragoo2021 branch May 27, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants