Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added COMPRESS_STREAMS flag #36

Merged
merged 1 commit into from Sep 21, 2022
Merged

added COMPRESS_STREAMS flag #36

merged 1 commit into from Sep 21, 2022

Conversation

christopherpickering
Copy link
Contributor

@christopherpickering christopherpickering commented Sep 21, 2022

Thanks for the tool @alexprengere and others!

This pr is to close #33 and close #35 while still supporting folks how want to disable stream compression.

v 1.12 has also broken compression for my site's css and js.

To disable stream compression add COMPRESS_STREAMS=False to the flask config.

The default (to make flask-compress continue working with the many existing live sites... is COMPRESS_STREAMS=True.

@gilad9366
@raphaeljolivet

I also added in tests to verify the changes.

@alexprengere
Copy link
Collaborator

alexprengere commented Sep 21, 2022

Thank you for stepping up and writing this PR. I will merge it and make a release, as it looks like the practical thing to do.
I still have hope that there would be some way to dissociate "regular streaming" vs "serving static content", perhaps changing a bit core Flask if not possible today.

@alexprengere alexprengere merged commit 079b215 into colour-science:master Sep 21, 2022
@christopherpickering
Copy link
Contributor Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS and JS static files not being compressed gzip not work with v1.12
2 participants