Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of May 2022, MIME type
application/javascript
has become obsolete in favour oftext/javascript
. This may explain why one user has reported that their .js files were not being compressed.The IETF has released RFC 9239 to explain the deprecation. The official list of MIME types posted by the IANA shows that
text/javascript
is active whileapplication/javascript
is obsoleted.In the backend if Flask is not given a MIME type, it will attempt to guess it. Here is a series of steps that Flask takes to guess the mimetype
mimetype
argument.send_file
calls werkzeug.utils.send_file that will attempt to guess the MIME type by calling mimetypes.guess_type utilizing the cpython mimetypes libraryFor now users may include
app.config['COMPRESS_MIMETYPES'].append('text/javascript')
in their app until this PR is merged.