Change future config default to true as docs state it should be #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colszowka
added a commit
that referenced
this pull request
Aug 19, 2011
Change future config default to true as docs state it should be
|
Thanks, well observed :) |
…he documentation as it states as if it were true: "Articles with a date in the future will not appear on the site, thus allowing you to prepare article that should be published later."
|
No problem, happy to contribute. :) Still going strong with Serious. I have another topic branch with documentation updates. I haven't edited it in awhile so I'll just push that through sometime today to get your feedback at least. Hopefully that gets incorporated as well. |
|
Yikes! Sorry @colszowka I realize I made a big mistake here. The value should be false. The tests are failing since the default value is true meaning future posts are included but that is incorrect. Per the documentation should be false so posts with a future date are NOT included. Sorry. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for the future config item should be true after reading the documentation as it states as if it were true: "Articles with a date in the future will not appear on the site, thus allowing you to prepare article that should be published later."