Recent versions of rubocop doesn't support ruby 1

and I don't think we need to run rubocop for all ruby versions
simplecov-ruby · Dec 26, 2016 · d68dd1a · d68dd1a
1 parent 1691108
commit d68dd1a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/Gemfile b/Gemfile
@@ -28,7 +28,7 @@ group :test do
     gem "cucumber"
     gem "phantomjs", "~> 1.9"
     gem "poltergeist"
-    gem "rubocop"
+    gem "rubocop" unless RUBY_VERSION.start_with?("1.")
     gem "test-unit"
   end
   gem "json", RUBY_VERSION.start_with?("1.") ? "~> 1.8" : "~> 2.0"

diff --git a/Rakefile b/Rakefile
@@ -27,10 +27,15 @@ rescue LoadError
 end
 
 # Cucumber integration test suite is for impls that work with simplecov only - a.k.a. 1.9+
-if RUBY_VERSION >= "1.9"
+if RUBY_VERSION.start_with? "1.8"
+  task :default => [:spec]
+else
   require "cucumber/rake/task"
   Cucumber::Rake::Task.new
-  task :default => [:spec, :cucumber, :rubocop]
-else
-  task :default => [:spec]
+
+  if RUBY_VERSION.start_with? "1.9"
+    task :default => [:spec, :cucumber]
+  else
+    task :default => [:spec, :cucumber, :rubocop]
+  end
 end