Loosen multi_json dependency #132

Closed
nirvdrum opened this Issue May 10, 2012 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

nirvdrum commented May 10, 2012

I commented on b496fd3, but please loosen the multi_json dependency. Simplecov uses it as a transitive dependency, but a lot of other libraries do as well, so it affects an entire dependency tree. Relying on the new API is no less a breaking change than go straight to multi_json 2.0. Feature detection of the APIs would mitigate against this. In any event, at the very least the move shouldn't happen in a point release.

@colszowka colszowka added a commit that referenced this issue May 10, 2012

@colszowka colszowka Added transparent compatibility with MultiJson legacy api for #132
Original source for the updated API was #122.

Also see sferik/rails@5e62670
for the source implementation of this.
c9120e6

colszowka was assigned May 10, 2012

@colszowka colszowka added a commit that referenced this issue May 10, 2012

@colszowka colszowka Added appraisal gem for testing against different gem dependency vers…
…ions.

Also updated developer instructions in README and test setup both for local
and CI.

This became neccessary to ensure that older versions of multi_json are
supported, see #132.
f29a61b
Contributor

nirvdrum commented May 10, 2012

Thanks. I had never heard of appraisal before. I'll have to check that out.

Owner

colszowka commented May 10, 2012

Version 0.6.3 is out and should fix this problem, thanks for the report.

colszowka closed this May 10, 2012

@jperkin jperkin pushed a commit to joyent/pkgsrc-legacy that referenced this issue Dec 9, 2013

taca Update ruby-simplecov to 0.6.4.
v0.6.4, 2012-05-10 ([changes](colszowka/simplecov@v0.6.3...v0.6.4))
-------------------

  * [BUGFIX] Encoding issues with ISO-8859-encoded source files fixed.
    See colszowka/simplecov#117. (thanks to @Deradon)
  * [BUGFIX] Ensure ZeroDivisionErrors won't occur when calculating the coverage result, which previously
    could happen in certain cases. See colszowka/simplecov#128. (thanks to @japgolly)
  * [REFACTORING] Changed a couple instance variable lookups so SimpleCov does not cause a lot of warnings when
    running ruby at a higher warning level. See colszowka/simplecov#106 and
    colszowka/simplecov#119. (thanks to @mvz and @gioele)


v0.6.3, 2012-05-10 ([changes](colszowka/simplecov@v0.6.2...v0.6.3))
-------------------

  * [BUGFIX] Modified the API-changes for newer multi_json versions introduced with #122 and v0.6.2 so
    they are backwards-compatible with older multi_json gems in order to avoid simplecov polluting
    the multi_json minimum version requirement for entire applications.
    See colszowka/simplecov#132
  * Added appraisal gem to the test setup in order to run the test suite against both 1.0 and 1.3
    multi_json gems and ensure the above actually works :)
0410186

@jsonn jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 11, 2014

taca Update ruby-simplecov to 0.6.4.
v0.6.4, 2012-05-10 ([changes](colszowka/simplecov@v0.6.3...v0.6.4))
-------------------

  * [BUGFIX] Encoding issues with ISO-8859-encoded source files fixed.
    See colszowka/simplecov#117. (thanks to @Deradon)
  * [BUGFIX] Ensure ZeroDivisionErrors won't occur when calculating the coverage result, which previously
    could happen in certain cases. See colszowka/simplecov#128. (thanks to @japgolly)
  * [REFACTORING] Changed a couple instance variable lookups so SimpleCov does not cause a lot of warnings when
    running ruby at a higher warning level. See colszowka/simplecov#106 and
    colszowka/simplecov#119. (thanks to @mvz and @gioele)


v0.6.3, 2012-05-10 ([changes](colszowka/simplecov@v0.6.2...v0.6.3))
-------------------

  * [BUGFIX] Modified the API-changes for newer multi_json versions introduced with #122 and v0.6.2 so
    they are backwards-compatible with older multi_json gems in order to avoid simplecov polluting
    the multi_json minimum version requirement for entire applications.
    See colszowka/simplecov#132
  * Added appraisal gem to the test setup in order to run the test suite against both 1.0 and 1.3
    multi_json gems and ensure the above actually works :)
93cae9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment