Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluebird Dependency #4

Closed
joshrivers opened this issue Jul 7, 2015 · 4 comments
Closed

Bluebird Dependency #4

joshrivers opened this issue Jul 7, 2015 · 4 comments

Comments

@joshrivers
Copy link

Hey, looks like bluebird was added to package.json as a dev-dependency rather than a production dependency, and I think it's needed at runtime. Can you take a peek?

@colthreepv
Copy link
Owner

Sure, my mistake, the idea was to make it a dev dependency to use bluebird only for debugging purposes.

i'm refactoring the code to not require it at all, since functionality is covered by native Promises

@joshrivers
Copy link
Author

I'm still crashing with

Error: Cannot find module 'bluebird'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/Users/riversj/vagrant/boot2docker/zipwhip-apispec/editor-dock/node_modules/express-raml-store/api.js:6:28)

on Node v0.12.5

@colthreepv
Copy link
Owner

mmm Indeed, I read up that node 0.12.x had native promises always enabled, anyway native promises are not a good choice for any serious module, since they have memory leaks

I'll make bluebird a must and just get over with it.

@colthreepv colthreepv reopened this Jul 9, 2015
@colthreepv
Copy link
Owner

Really thanks for your patience, Josh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants