pass ml_model_settings directly to the self.parameters

columnflow · May 21, 2024 · 4a94a78 · 4a94a78
1 parent 51f8356
commit 4a94a78
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/columnflow/tasks/framework/mixins.py b/columnflow/tasks/framework/mixins.py
@@ -1403,7 +1403,11 @@ def resolve_param_values(cls, params: dict[str, Any]) -> dict[str, Any]:
             analysis_inst = params["analysis_inst"]
 
             # NOTE: we could try to implement resolving the default ml_model here
-            ml_model_inst = cls.get_ml_model_inst(params["ml_model"], analysis_inst, **params["ml_model_settings"])
+            ml_model_inst = cls.get_ml_model_inst(
+                params["ml_model"],
+                analysis_inst,
+                parameters=params["ml_model_settings"],
+            )
             params["ml_model_inst"] = ml_model_inst
 
             # resolve configs
@@ -1437,7 +1441,7 @@ def __init__(self, *args, **kwargs):
             self.ml_model,
             self.analysis_inst,
             configs=list(self.configs),
-            **self.ml_model_settings,
+            parameters=self.ml_model_settings,
         )
 
     def store_parts(self) -> law.util.InsertableDict[str, str]:
@@ -1531,6 +1535,7 @@ def resolve_param_values(cls, params: dict[str, Any]) -> dict[str, Any]:
                     params["ml_model"],
                     analysis_inst,
                     requested_configs=[config_inst],
+                    parameters=params["ml_model_settings"],
                 )
             elif not cls.allow_empty_ml_model:
                 raise Exception(f"no ml_model configured for {cls.task_family}")
@@ -1547,6 +1552,7 @@ def __init__(self, *args, **kwargs):
                 self.ml_model,
                 self.analysis_inst,
                 requested_configs=[self.config_inst],
+                parameters=self.ml_model_settings,
             )
 
     def store_parts(self) -> law.util.InsertableDict: