Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HistogramsUser base and inspection tasks #432

Merged
merged 3 commits into from
May 28, 2024

Conversation

mafrahm
Copy link
Contributor

@mafrahm mafrahm commented May 15, 2024

This PR implements base tasks for loading histograms in Columnflow + two tasks that implement these base tasks for debugging purposes and as a simple exemplary usecase.

This task call loads histograms for only the nominal shift

law run cf.InspectHistograms --version v1 --variables jet1_pt --shift nominal --processes tt_sl

This task call loads histograms for nominal, murf_envelope_up, and murf_envelope_down

law run cf.InspectShiftedHistograms --version v1 --variables jet1_pt --shift-sources murf_envelope --processes tt_sl

@mafrahm mafrahm added enhancement New feature or request priority-medium Medium priority stuff labels May 15, 2024
@mafrahm mafrahm requested a review from riga May 15, 2024 13:18
@mafrahm mafrahm self-assigned this May 15, 2024
Copy link
Member

@pkausw pkausw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @mafrahm ! I think this will make e.g. evaluating ABCD methods much more feasible. It would be great if you could implement the small changes that I mention inline 😬

columnflow/tasks/framework/histograms.py Outdated Show resolved Hide resolved
@mafrahm mafrahm force-pushed the feature/histograms_base_tasks branch from 282d6ef to 0d7757d Compare May 17, 2024 06:48
@mafrahm mafrahm requested a review from pkausw May 17, 2024 06:49
Copy link
Member

@pkausw pkausw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an even more minor comment, almost done 👍

columnflow/tasks/framework/histograms.py Show resolved Hide resolved
Copy link
Member

@pkausw pkausw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@pkausw pkausw merged commit 2b8c051 into master May 28, 2024
8 checks passed
@pkausw pkausw deleted the feature/histograms_base_tasks branch May 28, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-medium Medium priority stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants