DEP Upgrade frontend build stack #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/4/frontend-build-stack
branch
from
596e18d
to
8b3e3ac
Compare
GuySartorelli
force-pushed
the
pulls/4/frontend-build-stack
branch
from
8b3e3ac
to
29cd25e
Compare
emteknetnz
requested changes
Jan 30, 2023
There was a problem hiding this comment.
Code changes look fine
Want to see if this issue was caused by comments module, or this module before merging
GuySartorelli
force-pushed
the
pulls/4/frontend-build-stack
branch
from
311e0b1
to
563f253
Compare
|
Turns out that was caused by a removed method still being called. Fixed now. |
emteknetnz
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-admin#1389 for a wider discussion on most of the changes
Parent issue