Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using "options.domain" causes some problems in request #4

Open
FrankyBoy opened this issue Oct 10, 2014 · 1 comment
Open

using "options.domain" causes some problems in request #4

FrankyBoy opened this issue Oct 10, 2014 · 1 comment

Comments

@FrankyBoy
Copy link

You get some nice error message starting like so...

events.js:86
    this.domain.enter();
                ^
TypeError: Object yourDomain has no method 'enter'
    at Request.emit (events.js:86:17)
    at IncomingMessage.<anonymous> (D:\git\bwin-bcm-bindings\bwin-bcm-bindings\node_modules\request\request.js:1108:12)

suggestion would be to rename "domain" to "ntlm_domain" to avoid this collision. Will provide patch asap.

FrankyBoy referenced this issue in FrankyBoy/request-ntlm Oct 10, 2014
…lready uses that for something (which fails)
@bignis
Copy link

bignis commented Aug 13, 2015

This appears to be directly related to nodejs/node-v0.x-archive#3922

apasquale pushed a commit to apasquale/request-ntlm that referenced this issue Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants